✨ (kubebuilder) new config image job for kube-rbac-proxy image #29351
Conversation
k8s-ci-robot
added
cncf-cla: yes
camilamacedo86
force-pushed
the
kubebuilder-proxy-image
branch
from
575a238
to
c0313c4
Compare
camilamacedo86
changed the title
| - --env-passthrough=PULL_BASE_REF | ||
| - --with-git-dir | ||
| - --gcb-config=build/cloudbuild_kube-rbac-proxy.yaml | ||
| - . |
There was a problem hiding this comment.
suggestion: instead of using --gcb-config here, probably you want to create a new directory in https://github.com/kubernetes-sigs/kubebuilder/tree/kube-rbac-proxy-releases with a proper cloudbuild, and point to that directory
eg.:
args:
....
- images/
And add a new cloudbuild.yaml inside this directory (see https://github.com/kubernetes/ingress-nginx/blob/main/cloudbuild.yaml). In this case if you want to test different combinations of cloudbuild.yaml later you won't need to change the one that is already working.
There was a problem hiding this comment.
ok I see it here: https://github.com/kubernetes-sigs/kubebuilder/pull/3362/files
let me continue the discussion there
There was a problem hiding this comment.
So, I understand that is right. Am I right?
See that I am doing like : https://github.com/kubernetes/test-infra/blob/3b85f96f30d6f1ce48639ccbdbde396cc3c8b183/config/jobs/image-pushing/k8s-staging-kustomize.yaml#LL28C1-L38C18
Note that for Kubebuilder, we do not use docker to build the image.
So, I understand that when we merge this one, we should see a new trigger created in the GCP, such as we have now:
There was a problem hiding this comment.
+1 for this suggestion, but not blocking
put a hold in case
camilamacedo86
force-pushed
the
kubebuilder-proxy-image
branch
from
f9b62dd
to
7baae2b
Compare
|
Hi @rikatz, I did the changes could we get this one merged, and then we try it out to see if it will work? |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
@camilamacedo86: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description
Creating a job to trigger the build of the image gcr.io/kubebuilder/kube-rbac-proxy in the new registry.
More info: kubernetes-sigs/kubebuilder#3362
Motivation: kubernetes-sigs/kubebuilder#3230
Closes: https://github.com/kubernetes/test-infra/pull/28803/files